Skip to content

Conversation

@whyoleg
Copy link
Member

@whyoleg whyoleg commented Sep 24, 2020

Main goal of PR is preparation for K/N target + improving nodejs testing

  • Rewrite tests to use suspend before and after tests - needed for better testing of nodejs
  • use mocha for nodejs tests - before it was karma which is more for browser
  • fix some issues for nodejs IR regarding cancelling
  • cleanup playground + move TCP to common (for future Native)
  • minor: payload creation from ByteArrays
  • minor: change a little JS logger to not print null all time where exception is null

add karma config to fix timeouts for JS
move LocalTransportTest to common
…tter testing of K/N)

use mocha for nodejs tests
fix some strange issues for JS IR
@whyoleg whyoleg added the task label Sep 24, 2020
@whyoleg whyoleg added this to the 0.10.0 milestone Sep 24, 2020
@yschimke yschimke removed their request for review September 24, 2020 18:39
@yschimke
Copy link
Member

Opting out - probably won't get time in next few days given a big PR

@whyoleg
Copy link
Member Author

whyoleg commented Oct 1, 2020

@yschimke @OlegDokuka any review, or I will merge it? Native support is ready and it depends on it

@yschimke
Copy link
Member

yschimke commented Oct 1, 2020

No opinion. Land if it's blocking forward progress.

@whyoleg whyoleg merged commit fa2a9b0 into master Oct 3, 2020
@whyoleg whyoleg deleted the task/tests-improvements branch October 3, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants