Fixed maximum length of route metadata #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed maximum length of route metadata
Motivation:
I encountered problem in our project where we are using rsocket to communication with Java server.
We have for some legacy reason very long URL path to Java endpoint which is around 138 characters long.
In this case the rsocket throw error on preparation of length byte for the tag. From the code I believe that the intention was to allow size of 0 - 255 but right now it is -128 to 127 and that raise the error. Also length check was wrong in this case since we have 256 "values" with zero included but maximum length is still 255.
Modifications:
I have fix the validation to allow up to 255 length and changed '>b' range of -128 to 127 to '>B' which mean range of 0 to 255.
Result:
Tag length validation should now correctly support up to 255 characters.