Skip to content

Conversation

@pemocarlo
Copy link
Contributor

This adds alternative solutions to the reading comprehension exercise Assignment
via advanced indexing
of the chapter Advanced indexing from Module 3

This adds alternatives to the reading comprehension exercise _Assignment
via advanced indexing_ of the chapter _Advanced indexing_ from Module 3
@rsokl rsokl added content creation Module 3 Questions/Problems with: The Essentials of NumPy labels Apr 12, 2020
@rsokl
Copy link
Owner

rsokl commented Apr 14, 2020

Thanks for this @CarlosPerezM ! I'll review this ASAP 😄

Copy link
Owner

@rsokl rsokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! One minor suggestion, but this should be good to go.

Address comments.
Remove example with `map` since it is not discussed elsewhere in PLYMI.
@pemocarlo
Copy link
Contributor Author

pemocarlo commented Apr 15, 2020

Thanks for the review!
And thanks for the great work!. I am really enjoying PLYMI, it has the right information to get up to speed with Python, quantity and quality wise. I also like the reading comprehension questions along the way.
I have some other ideas to add, so expect more PRs in the next days ;)

@rsokl
Copy link
Owner

rsokl commented Apr 15, 2020

Thanks for the kind feedback @CarlosPerezM ! And please do open those PRs - I am always looking to improve PLYMI, and am especially keen to add more reading comprehension problems and end-of-module problems. Also, let me know if you have any other feedback/critiques as you work through the site.

@rsokl rsokl merged commit cbbeb6e into rsokl:master Apr 15, 2020
@pemocarlo pemocarlo deleted the advanced_indexing_exercise branch April 15, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content creation Module 3 Questions/Problems with: The Essentials of NumPy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants