Style guide #74
Merged
Style guide #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidmascharka
left a comment
davidmascharka
left a comment
There was a problem hiding this comment.
Left comments on the first half or so. Will finish the rest up tomorrow and have more detailed comments on the overall thing.
davidmascharka
requested changes
Jan 23, 2019
Collaborator
davidmascharka
left a comment
davidmascharka
left a comment
There was a problem hiding this comment.
Last suggested changes added.
Overall comments: this is long. You know that already. I think the voice and everything are fine and it fits in with the feel of the odds and ends section. I think (pending these changes) that it's probably good to go up but I'll give it another read from top to bottom before final approval. I'm sure I'll be able to comment more faithfully on it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tooooo looooooong. I am soooo soooooorry.