Fix milter remove_headers array handling#5673
Merged
Conversation
Co-authored-by: v <v@rspamd.com>
|
Cursor Agent can help with this pull request. Just |
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
vstakhov
deleted the
cursor/RSP-26-fix-milter-remove-headers-array-handling-1740
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
UCL_ARRAYinremove_headersto allow removing multiple header instances by position.The previous implementation for
remove_headersinmilter.conly processed single integer values, ignoring arrays of integers. This prevented users from specifying multiple positions to remove for the same header (e.g.,remove_headers = { ['X-Example'] = {2, 3} }). This change extends the functionality to correctly iterate and processUCL_ARRAYtypes, aligning with the expected behavior and fixing bug RSP-26.Linear Issue: RSP-26