This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Configurable warning behaviour #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2015
JonRowe
force-pushed
the
configurable_warning_behaviour
branch
2 times, most recently
from
0e12d06 to
e83d66e
Compare
JonRowe
force-pushed
the
configurable_warning_behaviour
branch
from
e83d66e to
b67476d
Compare
Member
Author
|
Anyone free to review @rspec/rspec ? Appveyor failure is due to a connectivity issue... |
lib/rspec/core/configuration.rb
Outdated
Member
There was a problem hiding this comment.
I think this method would be better if this lambda was also extracted to a constant, that way we'd be at the same level of abstraction on the conditional. Thoughts?
Member
Author
There was a problem hiding this comment.
Don't see why not, done.
JonRowe
force-pushed
the
configurable_warning_behaviour
branch
from
b67476d to
3add554
Compare
Member
|
LGTM. Merge on green. |
JonRowe
added a commit
that referenced
this pull request
Aug 25, 2015
Configurable warning behaviour
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Configurable warning behaviour
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for #2005