Params are empty in view specs

[dolzenko]

Params hash is empty in views spec (i.e. no :controller and :action keys) which prevents url_for from generating routes when default controller is assumed.

I originally encountered the problem while trying to spec the view which uses will_paginate (and had to apply solution from [1]). But then browsing through links like [2] and [3] makes it seem like the params hash should be present. At least probably :controller should be set since there is controller detection anyway [4].

So I'm lost now, should I supply params[:controller], params[:action] manually from my views spec or it's a bug in RSpec/Rails?

[1] http://groups.google.com/group/will_paginate/browse_thread/thread/cd8dae9285441343?pli=1
[2] https://rspec.lighthouseapp.com/projects/5645/tickets/488
[3] http://groups.google.com/group/rspec/browse_thread/thread/761a071ead35a616/e6bb3075094d076b
[4] http://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/example/view_example_group.rb#L120

[dchelimsky]

RSpec, rails, and ruby versions?

[dolzenko]

RSpec: both HEAD and beta.19
Rails: 3.0.0.rc
Ruby: ruby 1.8.7 (2010-04-19 patchlevel 253) [i686-linux], MBARI 0x8770, Ruby Enterprise Edition 2010.02

[dchelimsky]

Can you show me the specific code, spec, and failure message? The generated view specs all pass against the generated scaffold views, which use methods that delegate to url_for (like form_for).

[dolzenko]

There is no specific code, here are the steps to reproduce:

1. Create rails 3.0.0.rc project
2. Add rspec beta.19 to Gemfile
3. rails generate rspec:install
4. rails generate scaffold Post title:string body:text
5. In say spec/views/posts/index.html.erb_spec.rb add <%= url_for(:page => 1) %>

Then rspec spec/views/posts/index.html.erb_spec.rb fails with

1) posts/index.html.erb renders a list of posts
    Failure/Error: render
    No route matches {:page=>1}

While http://localhost:3000/posts shows generated /posts?page=1 route just fine

[inspire22]

url_for defaults to using the current url? never been a documented feature that I've known about...?

http://railsapi.com/doc/rails-v3.0.0RC/classes/ActionView/Helpers/UrlHelper.html#M002585

[dolzenko]

Let's put it another way: documented <%= url_for(:action => 'new') %> will fail just the same way, since the controller is not set:

1) posts/index.html.erb renders a list of posts
    Failure/Error: render
    No route matches {:action=>"new"}

While http://localhost:3000/posts shows /posts/new

[dchelimsky]

Infer controller.request.path_params["controller"] from the file being
rendered in a view spec.

• Closed by 732a922.

[dolzenko]

Great, thanks!
Does that make sense to try to infer :action as well, or we should explicitly specify that in the spec?

[dchelimsky]

@dolzenko - I guess we could infer the action when the filename doesn't start with an underscore. WDYT?

[dolzenko]

Yes, that's what I was thinking, seems like a reasonable default.

[dchelimsky]

OK - re-opened and will close again once action is supported.

[dolzenko]

God is that Issues<-> IRC thing real? I thought that was a joke :)

And thanks for all the attention and super fast response to the ticket!

[dchelimsky]

Infer the controller action from the view path

• Closed by a28fd37.

[dolzenko]

Sorry for bugging you with that again, but is that normal that only request.path_parameters gets populated with that change and params stays empty? In real environment we get :controller and :action keys in params as well.

[dolzenko]

Aw, that's mind boggling. Further discrepancy is that in specs request.path_parameters has strings as keys, while in real environment it's symbols, and contrary to the comment here https://rails.lighthouseapp.com/projects/8994/tickets/3738-breaking-change-in-requestpath_parameters the request.path_parameters is just a Hash (not HashWithIndifferentAccess)