controller_path sometimes empty

[rwestgeest]

controller.controller_path is inferred from the rendered template.
This spec

    describe "table/some_action", :focus => true do
      it "should have an input in the form" do
        render :template => 'table/some_action'
        controller_path.should == 'table' 
      end
    end

passes, while this spec

    describe "table views" do
      describe "table/some_action", :focus => true do
        it "should have an input in the form" do
          render :template => 'table/some_action'
          controller_path.should == 'table'
        end
      end
    end

fails as controller_path is empty.

I think it would be fair to expect that wrapping such an example group in another should not break the spec.

This took me a while to figure out. I did not realize that controller path was used for

    url_for(:action => 'x') 

and

    render(:partial => 'y') 

Just saw strange errors indicating that there was something wrong with my controller in some (actually a lot but not all) of my view specs.

Cheers
Rob

[dchelimsky]

@rwestgeest is this still an issue for you with rspec-rails-2.9?

[alindeman]

Biasing towards closing after one month of no activity

[fotos]

I have a similar problem with controller_path being empty in my views using Rails 3.2.8.

Code like this:

<%= link_to "New", {:controller => controller_path, :action => "new"} %>

fails because #controller_path returns an empty string and the wrong link is generated in view tests, thus the matchers fail.

Easily reproducible. You can change features/view_specs/inferred_controller_path.feature as follows:

Feature: view spec infers controller path and action

  Scenario: infer controller path
    Given a file named "spec/views/widgets/new.html.erb_spec.rb" with:
      """
      require "spec_helper"

      describe "widgets/new" do
        it "infers the controller path" do
          expect(controller.request.path_parameters[:controller]).to eq("widgets")
          expect(controller.controller_path).to eq("widgets")
        end
      end
      """
    When I run `rspec spec/views`
    Then the examples should all pass

Feel free to ask for more info.

[fotos]

OK, this is definitely a regression. The above spec passes when using Rails 3.0.17.

[alindeman]

Thanks @fotos. I'll reopen and take a look soon.

[alindeman]

We stopped setting #controller_path in Rails >= 3.1 as of 4597ecd.

I'm not too familiar with exactly why, but I think we can still set #controller_path of TestController in Rails >= 3.1. @dchelimsky, do you know any reason why we shouldn't?

[alindeman]

The tests stayed green after the fix, so I biased towards merging.

Thanks @fotos for the test.

[fotos]

LGTM. Thanks for the quick fix @alindeman!