Route Helpers (fixed to not break controller specs) #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2011 13:49
This is based on the conversation at http://groups.google.com/group/rspec/browse_thread/thread/52a0935544557693/9d437ba9566527b0?lnk=gst&q=fiorini#9d437ba9566527b0. It enables a couple shortcuts for specifying routes that makes it a little more in line with Rails 3.
ControllerExampleGroup also includes RouteMatchers, and since Rails already implements get, post, put, etc for controller tests the helpers clash.
Author
|
shortcuts for specifying routes that align better with rails 3 APIs. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a conversation awhile back about this with David. He suggested the shortcuts which I have implemented. I'd love to see this get into core. Thoughts?