Warnings shown for 3rd party gems

[liam-m]

When running with rspec --warnings configured, I am getting lots of warnings for 3rd party gems:

/var/lib/gems/2.2.0/gems/simplecov-console-0.2.0/lib/simplecov-console.rb:86: warning: shadowing outer local variable - base
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/query/conditions/comparison.rb:278: warning: private attribute?
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/resource/persistence_state.rb:40: warning: private attribute?
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/property/object.rb:19: warning: mismatched indentations at 'end' with 'case' at 14
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/model/hook.rb:56: warning: shadowing outer local variable - hooks
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/model/property.rb:68: warning: shadowing outer local variable - properties
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/model/property.rb:86: warning: shadowing outer local variable - context
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/associations/relationship.rb:656: warning: shadowing outer local variable - source
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/associations/relationship.rb:433: warning: private attribute?
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/associations/relationship.rb:436: warning: private attribute?
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/associations/one_to_one.rb:67: warning: private attribute?
/var/lib/gems/2.2.0/gems/dm-core-1.2.1/lib/dm-core/support/logger.rb:71: warning: instance variable @log not initialized
/var/lib/gems/2.2.0/gems/dm-constraints-1.2.0/lib/data_mapper/constraints/relationship/one_to_many.rb:20: warning: shadowing outer local variable - resource
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/sql/table_creator.rb:17: warning: `&' interpreted as argument prefix
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/sql/table_modifier.rb:14: warning: `&' interpreted as argument prefix
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/sql/mysql.rb:34: warning: assigned but unused variable - statement
/var/lib/gems/2.2.0/gems/dm-serializer-1.2.2/lib/dm-serializer/to_xml.rb:105: warning: assigned but unused variable - root
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations/formats/email.rb:59: warning: assigned but unused variable - pattern
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations/formats/email.rb:59: warning: character class has duplicated range
/var/lib/gems/2.2.0/gems/data_objects-0.10.16/lib/data_objects/transaction.rb:54: warning: method redefined; discarding old prepare
/var/lib/gems/2.2.0/gems/data_objects-0.10.16/lib/data_objects/transaction.rb:50: warning: previous definition of prepare was here
/var/lib/gems/2.2.0/gems/data_objects-0.10.16/lib/data_objects/logger.rb:119: warning: instance variable @log not initialized
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/adapters/dm-do-adapter.rb:57: warning: assigned but unused variable - success
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/adapters/dm-do-adapter.rb:164: warning: assigned but unused variable - table_name
/var/lib/gems/2.2.0/gems/dm-migrations-1.2.0/lib/dm-migrations/adapters/dm-mysql-adapter.rb:95: warning: method redefined; discarding old storage_engine
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations/auto_validate.rb:34: warning: instance variable @disable_auto_validations not initialized
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations/auto_validate.rb:34: warning: instance variable @disable_auto_validations not initialized
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations.rb:155: warning: method redefined; discarding old valid_for_default?
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations.rb:155: warning: previous definition of valid_for_default? was here
/var/lib/gems/2.2.0/gems/dm-validations-1.2.0/lib/dm-validations.rb:155: warning: method redefined; discarding old valid_for_default?

I believe that #44 and 4381f7d were intended to stop this, but for some reason this doesn't seem to be working in this case. The environment is using Vagrant and rvm (ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux-gnu]).

This is with rspec 3.3.2

Am I doing something wrong or is this a bug?

[myronmarston]

Ruby's warning mode is global: it's either on for everything or off for everything. It provides no way to turn it on for only specific files, gems, classes or modules. RSpec provides a --warnings option that simply enables Ruby's warning mode. It can help you keep your gem warning free but can also be quite noisy with warnings you can't do anything about when.

I believe that #44 and 4381f7d were intended to stop this, but for some reason this doesn't seem to be working in this case.

Those are not intended to do anything about this for end users. There's some logic in rspec support that we use in the rspec test suites to ensure none of our code issues warnings, but it comes with lots of caveats and doesn't work in all situations. It's not a general purpose tool and It's not something we're will to maintain for end users.

Am I doing something wrong or is this a bug?

Neither. The --warnings flag is causing all the ruby warnings to be printed. Since your'e using a number of gems that trigger warnings, it's probably not useful for you.