chore(eval): add migrate-to-rstest eval and report#54
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7eae3143a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SoonIter
approved these changes
Apr 28, 2026
fi3ework
added a commit
that referenced
this pull request
Apr 28, 2026
Pre-existing formatting drift from #54 picked up by `prettier -c .` in CI. Whitespace-only — column padding tightened in two markdown tables.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills-test/migrate-to-rstest/evals/evals.jsonandreport.md, preserving the migrate-to-rstest evaluation data that was previously kept on themigrate-to-rstest-evalbranch before the evaluator infra (chore(infra): add rstack-skill-evaluator skill #49) landed.rstack-skill-evaluator'sdigestinskills-lock.yamlfrom a sha256 to"", matching how skills-package-manager v0.9.0 (chore(deps): upgrade skills-package-manager to v0.9.0 #52) treatslink:entries (same aspr-creator). This is whatpnpm installwrites locally — the previous value was a leftover from chore(infra): add rstack-skill-evaluator skill #49 being branched off pre-v0.9.0.The eval
evals.jsonschema extends the existing one (rsbuild / rslib) withfixture_root,runs_root,notes, plus per-evalfixture/pre_migration_baseline, because rstest fixtures live outside the repo (under/tmp/agent-skills-evals/...) rather than as in-tree projects. Core fields (skill_name,evals[],eval_name,prompt,assertions) match.The skill code itself (
skills/migrate-to-rstest/SKILL.mdandreferences/) is intentionally not brought over — main already has the more refined version from #51 ("tighten principles and defer to official guides"), and the branch's older copy would regress it.Test plan
evals.jsonschema is acceptable to therstack-skill-evaluatorskill (or the schema is documented as evolving)