Skip to content

chore(eval): add migrate-to-rstest eval and report#54

Merged
fi3ework merged 4 commits intomainfrom
migrate-to-rstest-eval-report
Apr 28, 2026
Merged

chore(eval): add migrate-to-rstest eval and report#54
fi3ework merged 4 commits intomainfrom
migrate-to-rstest-eval-report

Conversation

@fi3ework
Copy link
Copy Markdown
Member

Summary

The eval evals.json schema extends the existing one (rsbuild / rslib) with fixture_root, runs_root, notes, plus per-eval fixture / pre_migration_baseline, because rstest fixtures live outside the repo (under /tmp/agent-skills-evals/...) rather than as in-tree projects. Core fields (skill_name, evals[], eval_name, prompt, assertions) match.

The skill code itself (skills/migrate-to-rstest/SKILL.md and references/) is intentionally not brought over — main already has the more refined version from #51 ("tighten principles and defer to official guides"), and the branch's older copy would regress it.

Test plan

  • CI green
  • Confirm evals.json schema is acceptable to the rstack-skill-evaluator skill (or the schema is documented as evolving)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7eae3143a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills-test/migrate-to-rstest/evals/evals.json
@fi3ework fi3ework enabled auto-merge (squash) April 28, 2026 09:37
@fi3ework fi3ework requested a review from SoonIter April 28, 2026 09:38
@fi3ework fi3ework merged commit 8201070 into main Apr 28, 2026
4 checks passed
@fi3ework fi3ework deleted the migrate-to-rstest-eval-report branch April 28, 2026 09:42
fi3ework added a commit that referenced this pull request Apr 28, 2026
Pre-existing formatting drift from #54 picked up by `prettier -c .` in CI.
Whitespace-only — column padding tightened in two markdown tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants