feat!: add tools parameter to skill.when#124
Merged
chenjiahan merged 3 commits intomainfrom Apr 14, 2026
Merged
Conversation
Timeless0911
force-pushed
the
david/skill-when-prompt-only
branch
from
b6ca9d8 to
a994401
Compare
Timeless0911
changed the title
Timeless0911
changed the title
Timeless0911
force-pushed
the
david/skill-when-prompt-only
branch
from
a994401 to
73d60e3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6ca9d86d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chenjiahan
reviewed
Apr 14, 2026
Timeless0911
changed the title
Timeless0911
changed the title
chenjiahan
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill.whenand pass a single context object instead of positional argumentsskill.whenscoped to interactive prompt visibility while explicit--skillvalues remain authoritative--helplisting all optional skills and add coverage for the updated APIBreaking Change
extraSkills.whennow receives a single context object instead of positional parameters.Before:
After: