Skip to content

test: revert color workaround from @rstest/core 0.8.2#49

Merged
chenjiahan merged 1 commit intorstackjs:mainfrom
fi3ework:wr
Feb 5, 2026
Merged

test: revert color workaround from @rstest/core 0.8.2#49
chenjiahan merged 1 commit intorstackjs:mainfrom
fi3ework:wr

Conversation

@fi3ework
Copy link
Member

@fi3ework fi3ework commented Feb 5, 2026

revert color workaround from @rstest/core 0.8.2, just like before.

@gemini-code-assist
Copy link

Summary of Changes

Hello @fi3ework, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the @rstest/core testing library to its latest patch version, 0.8.3. This update allows for the removal of a specific workaround related to color output in tests, simplifying the test code and leveraging improvements within the updated testing framework. The changes primarily involve dependency manifest updates and corresponding test file adjustments.

Highlights

  • Dependency Upgrade: The @rstest/core testing framework has been updated from version 0.8.2 to 0.8.3.
  • Color Workaround Reversion: A previous workaround involving stubbing the FORCE_COLOR environment variable in chalk tests has been removed, indicating that the issue is resolved in the new @rstest/core version.
  • Test Utility Cleanup: The rs utility import, previously used for test helpers like environment variable stubbing, has been removed from tests/prebundle.test.ts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Updated the @rstest/core dependency from ^0.8.2 to ^0.8.3.
  • pnpm-lock.yaml
    • Updated the locked version of @rstest/core from 0.8.2 to 0.8.3.
    • Removed the entry for @rsbuild/core@1.7.2.
    • Updated @rstest/core@0.8.3's dependency on @rsbuild/core from 1.7.2 to 1.7.3.
  • tests/prebundle.test.ts
    • Removed the rs import from @rstest/core.
    • Eliminated the rs.stubEnv('FORCE_COLOR', '1') and rs.unstubAllEnvs() calls within the chalk verification test.
Activity
  • No specific activity (comments, reviews, approvals) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @rstest/core to version 0.8.3 and correctly removes a workaround for color output in tests that is no longer needed. The dependency updates in package.json and pnpm-lock.yaml are correct, and the removal of the workaround logic from tests/prebundle.test.ts simplifies the code. The changes are straightforward and improve maintainability. I see no issues with this pull request.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan merged commit 15c10fe into rstackjs:main Feb 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants