Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript version to 6.0.2 and modifies the tsconfig.json configuration, including updating the target to ES2023 and switching to nodenext for module resolution. Feedback was provided regarding the removal of the strict compiler option, which is recommended to be kept for better type safety.
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s TypeScript toolchain to v6.0.2 and aligns compilation settings with a NodeNext/ESM-oriented tsconfig.json.
Changes:
- Upgrade
typescriptto 6.0.2 (and update lockfile accordingly). - Replace the root
tsconfig.jsoncompiler options with a NodeNext-focused configuration. - Reformat
package.json(whitespace/structure) while updating the TypeScript devDependency.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tsconfig.json | Updates compiler options for NodeNext module resolution and newer ECMAScript target/output layout. |
| package.json | Pins TypeScript to 6.0.2 and normalizes formatting. |
| pnpm-lock.yaml | Locks TypeScript 6.0.2 and updates peer/optional dependency resolution entries. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "nano-staged": "^0.9.0", | ||
| "playwright": "^1.58.2", | ||
| "simple-git-hooks": "^2.13.1", | ||
| "typescript": "6.0.2" |
There was a problem hiding this comment.
Upgrading to TypeScript 6.0.2 may be incompatible with the currently locked build tooling: rsbuild-plugin-dts@0.20.0 (pulled in via @rslib/core@0.20.0) declares a peerDependencies.typescript of ^5, so this change will likely produce peer-dependency warnings and may break d.ts generation. Consider bumping @rslib/core (and/or rsbuild-plugin-dts) to a version that supports TS 6 (e.g. rsbuild-plugin-dts@0.20.1+ which widens the peer range).
|
|
||
| typescript@5.9.3: | ||
| resolution: {integrity: sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==} | ||
| typescript@6.0.2: |
There was a problem hiding this comment.
typescript@6.0.2 is now locked, but rsbuild-plugin-dts@0.20.0 (also in this lockfile) declares peerDependencies.typescript: ^5. This unsupported peer range will typically cause install warnings and can break the d.ts build; consider updating the toolchain to a version that supports TS 6 (e.g. rsbuild-plugin-dts@0.20.1+, likely via bumping @rslib/core).
| typescript@6.0.2: | |
| typescript@5.5.4: |
Summary
tsconfig.jsonwith the shared NodeNext configuration.pnpm buildandpnpm test.Related Links