fix: remove profile and unsafeCache options#78
Conversation
chenjiahan
commented
Feb 26, 2026
- update @rspack/core dependency to 2.0.0-beta.3
- remove profile configuration option from config
- remove unsafeCache option from module configuration
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on aligning the project with the latest beta version of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the @rspack/core dependency to 2.0.0-beta.3 and removes the deprecated profile and unsafeCache configuration options. The changes are consistently applied across the codebase, including the README.md documentation, type definitions, tests, and dependency files. The code modifications correctly remove the specified options from the configuration chain. The changes are clean and align with the stated objectives of the pull request.
There was a problem hiding this comment.
Pull request overview
Updates rspack-chain to align with @rspack/core@2.0.0-beta.3 by removing configuration surface area that no longer exists upstream (profile and module.unsafeCache).
Changes:
- Bump
@rspack/coredev dependency to2.0.0-beta.3(and update lockfile accordingly). - Remove
profilefrom the chained config API (runtime, types, docs, and type-tests). - Remove
module.unsafeCachefrom the chained module API (runtime, types, and docs).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| types/test/rspack-chain-tests.ts | Updates type-level API coverage to stop using the removed .profile() method. |
| types/index.d.ts | Removes the profile() and module.unsafeCache() declarations from the public type surface. |
| src/index.js | Drops 'profile' from the list of generated chainable top-level config setters. |
| src/Module.js | Drops 'unsafeCache' from generated chainable module setters (keeps noParse). |
| package.json | Bumps @rspack/core devDependency and simplifies peer dependency range for v2. |
| pnpm-lock.yaml | Lockfile updates for @rspack/core@2.0.0-beta.3 and related bindings. |
| README.md | Removes documentation references/examples for profile and module.unsafeCache. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.