Skip to content

fix: remove profile and unsafeCache options#78

Merged
chenjiahan merged 1 commit intomainfrom
remove_options_0226
Feb 26, 2026
Merged

fix: remove profile and unsafeCache options#78
chenjiahan merged 1 commit intomainfrom
remove_options_0226

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

  • update @rspack/core dependency to 2.0.0-beta.3
  • remove profile configuration option from config
  • remove unsafeCache option from module configuration

Copilot AI review requested due to automatic review settings February 26, 2026 06:32
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on aligning the project with the latest beta version of @rspack/core. It updates the core dependency and concurrently removes configuration options, profile and unsafeCache, that are no longer supported or relevant in the newer Rspack version. This ensures compatibility and streamlines the configuration API by eliminating deprecated features, reflecting the evolution of the Rspack ecosystem.

Highlights

  • Dependency Update: The @rspack/core dependency has been updated to version 2.0.0-beta.3.
  • Configuration Removal: The profile configuration option has been removed from the main Rspack config.
  • Module Option Removal: The unsafeCache option has been removed from the module configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • README.md
    • Removed profile option from config example.
    • Removed unsafeCache option from module example.
    • Removed profile option from merge example.
  • package.json
    • Updated @rspack/core dev dependency from 2.0.0-canary-20260116 to 2.0.0-beta.3.
    • Adjusted @rspack/core peer dependency range.
  • pnpm-lock.yaml
    • Updated @rspack/core and various @rspack/binding package versions and their integrity hashes to 2.0.0-beta.3.
    • Updated @module-federation/runtime-tools peer dependency range for @rspack/core.
  • src/Module.js
    • Removed unsafeCache from the list of extended module options.
  • src/index.js
    • Removed profile from the list of extended config options.
  • types/index.d.ts
    • Removed profile method from the Config class type definition.
    • Removed unsafeCache method from the Config.Module namespace type definition.
  • types/test/rspack-chain-tests.ts
    • Removed the test case for the profile configuration option.
Activity
  • No human activity has been recorded for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @rspack/core dependency to 2.0.0-beta.3 and removes the deprecated profile and unsafeCache configuration options. The changes are consistently applied across the codebase, including the README.md documentation, type definitions, tests, and dependency files. The code modifications correctly remove the specified options from the configuration chain. The changes are clean and align with the stated objectives of the pull request.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates rspack-chain to align with @rspack/core@2.0.0-beta.3 by removing configuration surface area that no longer exists upstream (profile and module.unsafeCache).

Changes:

  • Bump @rspack/core dev dependency to 2.0.0-beta.3 (and update lockfile accordingly).
  • Remove profile from the chained config API (runtime, types, docs, and type-tests).
  • Remove module.unsafeCache from the chained module API (runtime, types, and docs).

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/test/rspack-chain-tests.ts Updates type-level API coverage to stop using the removed .profile() method.
types/index.d.ts Removes the profile() and module.unsafeCache() declarations from the public type surface.
src/index.js Drops 'profile' from the list of generated chainable top-level config setters.
src/Module.js Drops 'unsafeCache' from generated chainable module setters (keeps noParse).
package.json Bumps @rspack/core devDependency and simplifies peer dependency range for v2.
pnpm-lock.yaml Lockfile updates for @rspack/core@2.0.0-beta.3 and related bindings.
README.md Removes documentation references/examples for profile and module.unsafeCache.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 041a6e6 into main Feb 26, 2026
11 checks passed
@chenjiahan chenjiahan deleted the remove_options_0226 branch February 26, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants