Conversation
chenjiahan
commented
Mar 15, 2026
- update all references from webpack to rspack in code, tests and docs
- preserve legacy webpack API for backward compatibility
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically refactors the naming conventions within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the codebase by renaming all instances of webpack to rspack, which is consistently applied across the code, tests, and documentation. The change also correctly preserves the legacy webpack API on res.locals for backward compatibility, and this is well-tested. I have one suggestion to improve the documentation to make this backward compatibility explicit to users.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ed6d11517
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the dev-middleware’s public-facing naming and SSR integration points to be Rspack-first (while still keeping a legacy webpack SSR alias in some places), and aligns tests/types/docs accordingly.
Changes:
- Add
res.locals.rspack.devMiddlewareSSR state (alongside a legacyres.locals.webpack.devMiddlewarealias in the core middleware). - Rename hook/plugin identifiers and framework wrapper names from
webpack-dev-middlewaretorspack-dev-middleware. - Update TypeScript typings, tests, and README SSR documentation to reference the new
rspacklocals shape.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| types/utils/setupWriteToDisk.d.ts | Removes redundant typedef comments from generated typings. |
| types/index.d.ts | Extends ExtendedServerResponse.locals typing to include rspack devMiddleware context; updates JSDoc return wording. |
| test/utils/setupWriteToDisk.test.js | Updates test comments to reflect Rspack asset emitted behavior. |
| test/middleware.test.js | Updates hapi property access and SSR locals assertions to include rspack and keep webpack. |
| test/helpers/getCompilerHooks.js | Updates hook tap-name lookup to rspack-dev-middleware. |
| src/utils/setupWriteToDisk.js | Renames internal “assetEmitted callback installed” flag to a Rspack-specific key. |
| src/utils/setupOutputFileSystem.js | Updates TODO wording to reference rspack-dev-server. |
| src/utils/setupHooks.js | Renames compiler hook tap names to rspack-dev-middleware. |
| src/middleware.js | Sets SSR state on responses under both rspack and legacy webpack keys. |
| src/index.js | Renames logger / wrapper function identifiers and hapi decoration name to Rspack; updates SSR-related docs/comments accordingly. |
| README.md | Updates SSR docs to reference res.locals.rspack.devMiddleware and Rspack stats documentation. |
| package.json | Removes webpack keyword and webpack OpenCollective funding metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.