fix!: removes @fastify/express support#29
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the logic for selecting the appropriate request URL, particularly when dealing with frameworks or middleware that might modify Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves URL selection logic by introducing a shouldUseOriginalURL helper to handle cases where middleware rewrites req.url. The change is well-tested and also includes a cleanup of type definitions. My only suggestion is to improve error handling in the new helper function by documenting why an error is being ignored.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c50b62ddf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR improves getRequestURL behavior to better distinguish between framework-provided “original URL” fields (e.g., Fastify’s originalUrl) and cases where middleware has rewritten req.url, ensuring downstream filename resolution uses the correct URL form.
Changes:
- Added a
shouldUseOriginalURLhelper to only preferreq.originalUrlwhen it matches the encoded form ofreq.url. - Updated
getRequestURLto use this helper rather than always preferringoriginalUrlwhen present. - Refactored/moved compatible API type definitions in the generated
typesoutput and added targeted unit tests for the URL selection behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/utils/compatibleAPI.js |
Introduces shouldUseOriginalURL and updates getRequestURL selection logic for rewritten vs. decoded URLs. |
test/utils/compatibleAPI.test.js |
Adds unit tests covering getURL override, encoded originalUrl preference, and rewrite scenarios. |
types/utils/compatibleAPI.d.ts |
Updates the declarations to reflect the reorganized type definitions for this utility module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Our Fastify integration relied on
@fastify/express, so it was more of a compatibility path than first-class support. Over time, keeping that path adds extra framework-specific logic and maintenance overhead to a package that is primarily designed as an express-style middleware.Removing it helps keep the implementation focused and simpler to maintain.