refactor: move @types/connect-history-api-fallback to devDependencies

[chenjiahan]

The type definition @types/connect-history-api-fallback was moved from dependencies to devDependencies since it's only needed during development. Also updated the type import to use the Rspack DevServer type instead of directly importing from connect-history-api-fallback.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's dependency management and type definitions to improve accuracy and reduce unnecessary production dependencies. By moving a type definition package to development dependencies and aligning a specific type with the Rspack DevServer's internal types, the change ensures that the project's build and runtime environments are cleaner and more efficient, without altering core functionality.

Highlights

• Dependency Management: The type definition package @types/connect-history-api-fallback has been reclassified from a production dependency to a development dependency, as it is only required during the development phase.
• Type Definition Refactoring: The ConnectHistoryApiFallbackOptions type definition has been updated to derive its type from the Rspack DevServer type, removing the direct import from connect-history-api-fallback.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• package.json
  • Moved @types/connect-history-api-fallback from dependencies to devDependencies.
• pnpm-lock.yaml
  • Updated the lockfile to reflect the change in @types/connect-history-api-fallback's dependency type.
• src/types.ts
  • Removed direct import of Options as ConnectHistoryApiFallbackOptions from connect-history-api-fallback.
  • Imported DevServer type from @rspack/core.
  • Removed ConnectHistoryApiFallbackOptions from the public export list.
  • Redefined ConnectHistoryApiFallbackOptions using Exclude<NonNullable<DevServer['historyApiFallback']>, boolean>.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the project's dependencies by moving @types/connect-history-api-fallback from dependencies to devDependencies. This is appropriate as type definitions are only needed for development. The related type imports have also been updated to derive the ConnectHistoryApiFallbackOptions type from @rspack/core's DevServer type, which is a good practice to reduce direct dependencies and improve type safety. The changes are well-implemented and improve the project's dependency management.

[Copilot]

Pull request overview

Refactors how ConnectHistoryApiFallbackOptions is defined so the project no longer directly imports types from connect-history-api-fallback, and adjusts dependency placement for @types/connect-history-api-fallback.

Changes:

• Replaced the direct connect-history-api-fallback Options type import with a type derived from @rspack/core’s DevServer['historyApiFallback'].
• Moved @types/connect-history-api-fallback from dependencies to devDependencies.
• Updated pnpm-lock.yaml to reflect the dependency move.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/types.ts	Redefines ConnectHistoryApiFallbackOptions based on @rspack/core’s DevServer type instead of importing from connect-history-api-fallback.
package.json	Moves @types/connect-history-api-fallback to devDependencies.
pnpm-lock.yaml	Updates lockfile importer sections to match the dependency move.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.