Skip to content

chore: fix lint issues#196

Merged
chenjiahan merged 2 commits intomainfrom
chenjiahan/fix-lint-issues
Apr 13, 2026
Merged

chore: fix lint issues#196
chenjiahan merged 2 commits intomainfrom
chenjiahan/fix-lint-issues

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This PR fixes the current lint failures by replacing ts-comment suppressions with typed alternatives, adding a minimal local declaration for the rspack hot modules, and removing the unused getChildLogger plumbing.

Testing

  • pnpm lint
  • pnpm build

Related Links

  • None

@chenjiahan chenjiahan changed the title [codex] chore: fix lint issues chore: fix lint issues Apr 13, 2026
@chenjiahan chenjiahan marked this pull request as ready for review April 13, 2026 06:24
Copilot AI review requested due to automatic review settings April 13, 2026 06:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves current lint failures by removing TypeScript suppression comments and replacing them with typed alternatives, plus a small cleanup in the client logger plumbing.

Changes:

  • Replaced @ts-ignore / @ts-expect-error suppressions with explicit typing/casts and updated an ANSI escape regex to a TS-safe form.
  • Added local TypeScript module declarations for @rspack/core/hot/* imports used by the client runtime.
  • Simplified the client logger implementation by removing unused getChildLogger plumbing and tightening a stub hook implementation.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/normalizeOptions.test.ts Removes TS suppression comments by using a typed cast for snapshot normalization.
src/server.ts Minor refactor (letconst) in client transport selection to satisfy linting/immutability expectations.
client-src/utils/ansiHTML.ts Replaces octal escape sequence with \x1b to avoid TS parsing/lint issues.
client-src/rspack-hot.d.ts Adds minimal local module declarations for rspack HMR emitter/log imports.
client-src/modules/logger/Logger.ts Renames internals to “Rspack” and removes unused child logger wiring.
client-src/modules/logger/index.ts Updates SyncBailHook stub to a class and removes now-unused child logger creation path.
client-src/index.ts Switches to the locally-declared rspack hot log import name and updates usage accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e62569e5ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chenjiahan chenjiahan merged commit c692d90 into main Apr 13, 2026
7 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/fix-lint-issues branch April 13, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants