refactor: rename webpack-dev-server to rspack-dev-server#86
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive renaming operation, changing all instances of 'webpack-dev-server' to 'rspack-dev-server' across the codebase. This ensures consistency in branding and naming conventions, impacting client-side logic, server-side routing, and various testing configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request begins the refactoring process of renaming webpack-dev-server to rspack-dev-server. The changes made in the diff are correct. However, the refactoring seems incomplete as there are several other occurrences of the old name throughout the codebase. Since these are outside the changed lines in this pull request, I'm listing them here for your consideration to address in a follow-up:
-
src/server.ts: Several references towebpack-dev-serverremain.- Environment variables
WEBPACK_DEV_SERVER_BASE_PORT(line 326) andWEBPACK_DEV_SERVER_PORT_RETRY(line 333) could be renamed to use anRSPACK_prefix. - The IPC socket name
webpack-dev-server.sock(line 1092) should berspack-dev-server.sock. - An error message on line 1436 contains a path with
webpack-dev-server.
- Environment variables
-
tests/e2e/hot-and-live-reload.test.js:- The constant
INVALID_MESSAGEon line 20 is[webpack-dev-server] App updated. Recompiling...and should be updated.
- The constant
-
tests/e2e/__snapshots__/overlay.test.js.snap.webpack5:- The snapshot contains multiple instances of
<h1>webpack-dev-server is running...</h1>which should be updated. This likely originates from a test fixture that also needs to be updated.
- The snapshot contains multiple instances of
-
client-src/utils/sendMessage.ts:- The
postMessageevent type prefix is stillwebpackon line 19. This could be changed torspackfor consistency.
- The
-
client-src/modules/logger/Logger.ts:- The class
WebpackLoggerand its related symbols and error messages could be renamed to useRspackfor consistency.
- The class
There was a problem hiding this comment.
Pull request overview
This PR renames various runtime identifiers and endpoints from webpack-dev-server to rspack-dev-server across client code, server middleware routes, and E2E tests/snapshots.
Changes:
- Updated overlay iframe/container IDs and regenerated related snapshots/tests to match.
- Renamed built-in server routes (sockjs bundle, invalidate, open-editor) to
rspack-dev-server-prefixed paths. - Renamed URL query flags used to disable HMR/live reload to
rspack-dev-server-*and updated tests accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/overlay.test.js | Updates selectors/frame names used by overlay E2E tests to the new overlay IDs. |
| tests/e2e/hot-and-live-reload.test.js | Updates query params and assertions to the new rspack-dev-server-* flags. |
| tests/e2e/built-in-routes.test.js | Updates expected built-in route URLs to the new rspack-dev-server paths. |
| tests/e2e/snapshots/overlay.test.js.snap.webpack5 | Updates stored overlay HTML snapshots to match new element IDs. |
| src/servers/SockJSServer.ts | Changes the default sockjs bundle URL path returned by the server. |
| src/server.ts | Renames middleware route paths/names for sockjs bundle, invalidate, and open-editor endpoints. |
| client-src/overlay.ts | Renames overlay element IDs, Trusted Types policy name, and open-editor endpoint path. |
| client-src/index.ts | Renames the query flags used to disable hot/live reload in the client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updates all client, server, and test references from "webpack-dev-server" to "rspack-dev-server".