Skip to content

refactor: rename webpack-dev-server to rspack-dev-server#86

Merged
chenjiahan merged 3 commits intomainfrom
rename_webpack_dev_server_0228
Feb 28, 2026
Merged

refactor: rename webpack-dev-server to rspack-dev-server#86
chenjiahan merged 3 commits intomainfrom
rename_webpack_dev_server_0228

Conversation

@chenjiahan
Copy link
Member

Updates all client, server, and test references from "webpack-dev-server" to "rspack-dev-server".

Copilot AI review requested due to automatic review settings February 28, 2026 03:36
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a comprehensive renaming operation, changing all instances of 'webpack-dev-server' to 'rspack-dev-server' across the codebase. This ensures consistency in branding and naming conventions, impacting client-side logic, server-side routing, and various testing configurations.

Highlights

  • Client-side References: Updated all client-side code to use 'rspack-dev-server' instead of 'webpack-dev-server' for hot module replacement, live reload, and overlay elements.
  • Server-side References: Renamed server middleware paths and names, including those for the SockJS bundle, invalidation, and the open-editor functionality, to reflect 'rspack-dev-server'.
  • Test Updates: Modified end-to-end tests, including snapshots, built-in routes, hot/live reload, and overlay tests, to align with the new 'rspack-dev-server' naming convention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • client-src/index.ts
    • Updated search parameter checks for hot module replacement and live reload.
  • client-src/overlay.ts
    • Renamed trusted types policy name, iframe ID, content element ID, and open-editor URL.
  • src/server.ts
    • Renamed middleware names and paths for sockjs bundle, invalidate, and open-editor routes.
  • src/servers/SockJSServer.ts
    • Updated the sockjs bundle path.
  • tests/e2e/snapshots/overlay.test.js.snap.webpack5
    • Updated snapshot tests to reflect the new overlay IDs.
  • tests/e2e/built-in-routes.test.js
    • Updated test URLs for sockjs bundle and invalidate routes.
  • tests/e2e/hot-and-live-reload.test.js
    • Updated query parameters in test titles and logic for disabling hot module replacement and live reload.
  • tests/e2e/overlay.test.js
    • Updated selectors for the overlay iframe in various test scenarios.
Activity
  • No specific activity (comments, reviews, progress) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request begins the refactoring process of renaming webpack-dev-server to rspack-dev-server. The changes made in the diff are correct. However, the refactoring seems incomplete as there are several other occurrences of the old name throughout the codebase. Since these are outside the changed lines in this pull request, I'm listing them here for your consideration to address in a follow-up:

  • src/server.ts: Several references to webpack-dev-server remain.

    • Environment variables WEBPACK_DEV_SERVER_BASE_PORT (line 326) and WEBPACK_DEV_SERVER_PORT_RETRY (line 333) could be renamed to use an RSPACK_ prefix.
    • The IPC socket name webpack-dev-server.sock (line 1092) should be rspack-dev-server.sock.
    • An error message on line 1436 contains a path with webpack-dev-server.
  • tests/e2e/hot-and-live-reload.test.js:

    • The constant INVALID_MESSAGE on line 20 is [webpack-dev-server] App updated. Recompiling... and should be updated.
  • tests/e2e/__snapshots__/overlay.test.js.snap.webpack5:

    • The snapshot contains multiple instances of <h1>webpack-dev-server is running...</h1> which should be updated. This likely originates from a test fixture that also needs to be updated.
  • client-src/utils/sendMessage.ts:

    • The postMessage event type prefix is still webpack on line 19. This could be changed to rspack for consistency.
  • client-src/modules/logger/Logger.ts:

    • The class WebpackLogger and its related symbols and error messages could be renamed to use Rspack for consistency.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames various runtime identifiers and endpoints from webpack-dev-server to rspack-dev-server across client code, server middleware routes, and E2E tests/snapshots.

Changes:

  • Updated overlay iframe/container IDs and regenerated related snapshots/tests to match.
  • Renamed built-in server routes (sockjs bundle, invalidate, open-editor) to rspack-dev-server-prefixed paths.
  • Renamed URL query flags used to disable HMR/live reload to rspack-dev-server-* and updated tests accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/e2e/overlay.test.js Updates selectors/frame names used by overlay E2E tests to the new overlay IDs.
tests/e2e/hot-and-live-reload.test.js Updates query params and assertions to the new rspack-dev-server-* flags.
tests/e2e/built-in-routes.test.js Updates expected built-in route URLs to the new rspack-dev-server paths.
tests/e2e/snapshots/overlay.test.js.snap.webpack5 Updates stored overlay HTML snapshots to match new element IDs.
src/servers/SockJSServer.ts Changes the default sockjs bundle URL path returned by the server.
src/server.ts Renames middleware route paths/names for sockjs bundle, invalidate, and open-editor endpoints.
client-src/overlay.ts Renames overlay element IDs, Trusted Types policy name, and open-editor endpoint path.
client-src/index.ts Renames the query flags used to disable hot/live reload in the client.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit bf3e46f into main Feb 28, 2026
6 of 8 checks passed
@chenjiahan chenjiahan deleted the rename_webpack_dev_server_0228 branch February 28, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants