fix: narrow default node_modules exclude#123
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the plugin’s default exclude behavior so React Refresh ignores only true node_modules path segments (instead of any path containing the substring), and updates documentation/tests to reflect and validate that behavior.
Changes:
- Narrow default
excludefrom a broad/node_modules/i-style match to a path-segment match (/[\\/]node_modules[\\/]/). - Add a regression test + fixture to ensure paths whose names merely contain
node_modulesare still processed. - Update README to document the new default and example configuration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/options.ts |
Updates the default exclude regex used during options normalization and documents it in JSDoc. |
README.md |
Updates the documented default exclude and example patterns to match the new behavior. |
test/test.spec.ts |
Adds coverage for paths that contain node_modules as part of a directory name (not as a segment). |
test/fixtures/contains-node_modules-name/index.js |
Adds a new fixture used by the regression test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
97
to
99
| d(options, 'test', /\.(?:js|jsx|mjs|cjs|ts|tsx|mts|cts)$/); | ||
| d(options, 'exclude', /node_modules/i); | ||
| d(options, 'exclude', /[\\/]node_modules[\\/]/); | ||
| d(options, 'library'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR narrows the default
excludeoption so React Refresh skips only realnode_modulespath segments instead of any path containing thenode_modulessubstring. It also updates the README default and adds coverage for paths whose names merely containnode_modules.