chore(ci): remove stale release-napi.yml.yak workflow#209
Merged
Conversation
The .yak suffix disables this workflow, but the file remains a latent risk: it still contains a long-lived NPM_TOKEN credential reference, unpinned third-party actions, and a push-to-main trigger. Renaming it back to .yml (accidentally or maliciously) would immediately enable a publish path that bypasses the OIDC-based release-npm.yml flow. release-npm.yml already supersedes it for all npm publishing.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a disabled-by-extension GitHub Actions workflow that still contains a complete N-API build + npm publish pipeline, reducing latent supply-chain risk and ensuring the repo’s release process remains centered on the active release-npm.yml workflow.
Changes:
- Delete
.github/workflows/release-napi.yml.yak(inactive file that still embeds a publish pipeline and token-based npm auth).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hardfist
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete
.github/workflows/release-napi.yml.yak, a disabled-by-extension workflow that still carries a fully-formed npm publish pipeline.Why this matters
While the
.yaksuffix prevents GitHub Actions from loading the file, the file body remains a latent supply-chain risk:secrets.NPM_TOKENfor npm publishing — exactly the credential model recent supply-chain attacks (e.g. TanStack npm compromise) extract via runner memory. The activerelease-npm.ymlalready uses OIDC + provenance instead.on: push: branches: main, paths: npm/package.json. A rename from.yakback to.ymlwould silently re-enable an auto-publish path bypassing the manualworkflow_dispatchgate and theenvironment: npmreviewer inrelease-npm.yml.taiki-e/checkout-action@v1,actions/checkout@v4,actions/upload-artifact@v4,actions/download-artifact@v4,actions/setup-node@v4,goto-bus-stop/setup-zig@v2,cross-platform-actions/action@v0.25.0,addnab/docker-run-action@v3,docker/setup-qemu-action@v3,EndBug/version-check@v2— all floating tags vulnerable to tag-rewrite supply-chain attacks.release-npm.yml(workflow_dispatch + OIDC trusted publish + environment-gated) already supersedes every responsibility this file had.Test plan
release-napi.yml.yakrelease-npm.ymlremains the sole npm publish entry point