Skip to content

ci(codeql): add rust to code scanning languages#266

Merged
stormslowly merged 1 commit into
mainfrom
ci/codeql-scan-rust
Jun 3, 2026
Merged

ci(codeql): add rust to code scanning languages#266
stormslowly merged 1 commit into
mainfrom
ci/codeql-scan-rust

Conversation

@stormslowly
Copy link
Copy Markdown
Collaborator

Why

rspack-resolver is a Rust project, but the CodeQL workflow added in #265 only scans actions and javascript-typescript. The Rust source — the bulk of the codebase — was left uncovered.

What

Add rust to the CodeQL language matrix.

  • Uses build-mode: none so CodeQL analyzes from source instead of running a full cargo build, keeping the job light. (none is also the correct mode for the existing no-build languages.)
CodeQL coverage
Before (#265) actions, javascript-typescript
After actions, javascript-typescript, rust

Copilot AI review requested due to automatic review settings June 2, 2026 18:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the repository’s CodeQL workflow to include Rust scanning so the primary Rust codebase is covered by code scanning.

Changes:

  • Adds rust to the CodeQL language matrix.
  • Sets build-mode: none in the CodeQL init step (intended to keep the job light by avoiding a build).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/codeql.yml
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 2, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing ci/codeql-scan-rust (029c927) with main (94b9e14)

Open in CodSpeed

This is a Rust project, so the Rust source must be covered by CodeQL.
Use build-mode: none to analyze from source without a full cargo build,
keeping the analysis fast.
@stormslowly stormslowly force-pushed the ci/codeql-scan-rust branch from af2ac85 to 029c927 Compare June 3, 2026 06:56
@stormslowly stormslowly enabled auto-merge (squash) June 3, 2026 06:58
@stormslowly stormslowly disabled auto-merge June 3, 2026 08:30
@stormslowly stormslowly merged commit cb42e9a into main Jun 3, 2026
25 checks passed
@stormslowly stormslowly deleted the ci/codeql-scan-rust branch June 3, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants