Merged
Conversation
+ webpack to vite + eslint bump
mprzodala
reviewed
Dec 16, 2024
Collaborator
mprzodala
left a comment
mprzodala
left a comment
There was a problem hiding this comment.
I need to check build and how it works after publish :) but seems look good. I don't know what to do with eventrix/types from last version. I think we need to release new version or create backward compatibility.
Contributor
Author
|
I suggest creating a separate branch for these breaking changes and delaying their publication until we have more features ready for library users. Currently, these changes primarily benefit developers. Maybe we should use some tool like release-it and name branches accordingly to versions like: 'v1.x' and 'v2.x' or 'next'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes !25