add number_sections argument to markdown_document2 (closes #756) #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Sep 9, 2020
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
@atusy Thanks!
@cderv Feel free to merge this one after rstudio/rmarkdown#1879 is merged.
Collaborator
|
LGTM. Only one think: This feature relies on newer rmarkdown. So I did this 7f5af9c which is what to do in my experience. And we don't see this because ... we don't correctly test IMO. Once again, I think we should add test each time we add something. For now, I don't think the current test suite in bookdown allow to easily add test for this, so I'll do it later. |
Collaborator
|
It is not a perfect way to do it but I added a quick test because that is better to have one. |
Collaborator
Author
|
@cderv Thanks for changes! |
Collaborator
|
Thanks a lot @atusy ! |
yihui
added a commit
that referenced
this pull request
Sep 13, 2020
jonathan-g
added a commit
to jonathan-g/bookdown
that referenced
this pull request
Sep 24, 2020
Merge remote-tracking branch 'rstudio/master' into master # By Yihui Xie (4) and others # Via Yihui Xie * rstudio/master: the filenames use the separator - instead of _ with a4c97d8, when rendering multiple output formats, each format is rendered in a new session, so we no longer need clean_envir = TRUE Add a precision that `number_sections` default to TRUE and this will change outputs add number_sections argument to markdown_document2 (closes rstudio#756) (rstudio#938) fix rstudio#932: deprecate the clean_envir argument of render_book(), and use xfun::Rscript_call() to render multiple output formats (with each format in a new R session, so the formats aren rendered independently) make 'word' an alias of 'docx' in _bookdown.yml: https://stackoverflow.com/q/63678601/559676 Correctly encode twitter sharing url (rstudio#935) # Conflicts: # R/render.R
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge after rstudio/rmarkdown#1879
This PR adds number_sections argument to
markdown_document2and its family (e.g.,word_document2).I set
TRUEas a default value to be consistent with other formats (e.g.,html_document2).However, this may not be a good idea in case users' Rmd files manually numbered sections...