Skip to content

feat: Py-Shiny SCSS changes#1285

Merged
elnelson575 merged 11 commits intomainfrom
feat/python-toolbar-port
Jan 30, 2026
Merged

feat: Py-Shiny SCSS changes#1285
elnelson575 merged 11 commits intomainfrom
feat/python-toolbar-port

Conversation

@elnelson575
Copy link
Copy Markdown
Contributor

@elnelson575 elnelson575 commented Jan 30, 2026

Py-Shiny pulls in icons with svg tags and the faicon library and needs more specific rules to remove margins. Labels also need a small tweak to ensure they're centered.

  • Verify these changes don't affect bslib using the kitchen sink example

@elnelson575 elnelson575 marked this pull request as ready for review January 30, 2026 14:47
@elnelson575 elnelson575 requested a review from gadenbuie January 30, 2026 15:11
Copy link
Copy Markdown
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elnelson575 elnelson575 merged commit 11970a1 into main Jan 30, 2026
1 check passed
@elnelson575 elnelson575 deleted the feat/python-toolbar-port branch January 30, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants