Adjust sidebar function signature and require sidebar argument
#525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Mar 31, 2023
gadenbuie
changed the title
sidebar argument
cpsievert
added a commit
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Carson Sievert <cpsievert1@gmail.com> Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prequel to a series of sidebar-related PRs. Mostly, this PR adjusts the code style of the function signatures of
layout_sidebar()andsidebar()so arguments appear on their own line, which will reduce merge conflicts and dependences between the rest of the PRs I'm extracting from #516.