Skip to content

factor out is_keras_tensor due to 2.0 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javierluraschi merged 1 commit into from
Mar 21, 2019
Merged

factor out is_keras_tensor due to 2.0 #710

javierluraschi merged 1 commit into from
Mar 21, 2019

Conversation

@skeydan
Copy link

@skeydan skeydan commented Mar 21, 2019

This actually fixes all but 4(!!!) tests against today's 2.0 preview... tried to be conservative changing keras_array so hopefully should run against all required versions/implementations/backends (tested 1.12 and 1.13 and module(keras)...

The remaining 4 tests are all model saving / tfruns related, so it seems keras is in pretty good shape already ...

@skeydan
Copy link
Author

skeydan commented Mar 21, 2019

travis output for 2.0 preview:

OK: 238 SKIPPED: 1 FAILED: 4
  1. Failure: callback_model_checkpoint is called back 
  2. Failure: image data generator can be used for training 
  3. Failure: model can be saved and loaded from json 
  4. Failure: model can be saved and loaded from yaml

@javierluraschi javierluraschi merged commit 632cb84 into master Mar 21, 2019
@t-kalinowski t-kalinowski deleted the bugfix/tf-2.0-prev_1 branch December 29, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skeydan @javierluraschi