Skip to content

Conversation

@edavidaja
Copy link
Contributor

No description provided.

@machow machow self-requested a review November 3, 2022 14:26
@machow
Copy link
Collaborator

machow commented Nov 8, 2022

Thanks for this PR! I'm going to tweak quickly, so it doesn't try to run the azure tests on external PRs.

@machow
Copy link
Collaborator

machow commented Nov 8, 2022

Note that a small difference between this implementation and R is that R uses jsonlite with the auto_unbox=TRUE option, so pins-python can roundtrip {"a": [1]}, but R pins will re-write it as {"a": 1}. (but this seems okay is more a challenge with everything being a vector in R).

@machow machow merged commit c36de26 into rstudio:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants