Skip to content

Conversation

@isabelizimm
Copy link
Collaborator

@isabelizimm isabelizimm commented Sep 6, 2023

Currently, board_url is considered read-only without versioning support, but versioned=True on creation. This PR moves the NotImplementedError from the creation of any board with the attribute versioned=False and instead raises errors on relevant methods that should not be used with a read-only board.

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

What about:

  • pin_upload() (the error for writing happens in pin_write(), not the lower level function _pin_store())
  • pin_version_delete() (looks like it never calls pin_versions() to get the error)

@isabelizimm
Copy link
Collaborator Author

Good point! I added those pieces in, and make sure anything going through _pin_store with versioned=False gets a nice error.

@isabelizimm isabelizimm merged commit ea242bc into main Sep 7, 2023
@isabelizimm isabelizimm deleted the versioned-false branch September 7, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants