fix: ensure that pin metadata files are closed after reading them in#353
Merged
nealrichardson merged 3 commits intorstudio:mainfrom Mar 13, 2026
Merged
fix: ensure that pin metadata files are closed after reading them in#353nealrichardson merged 3 commits intorstudio:mainfrom
nealrichardson merged 3 commits intorstudio:mainfrom
Conversation
cpcloud
force-pushed
the
cleanup-after-pin-meta
branch
from
05d912c to
9c3ea5d
Compare
nealrichardson
force-pushed
the
cleanup-after-pin-meta
branch
from
61a97b1 to
3dc8c38
Compare
nealrichardson
approved these changes
Mar 13, 2026
Collaborator
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Thanks @cpcloud! I came across your PR this week and saw that CI was broken, so I fixed it upstream and rebased your PR, and it's all set now. Appreciate the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up leaked file handles from calling
_open_pin_meta(fromBoard.pin_metacalls). I observed aResourceWarningcoming frompin_metawhen running the test suite of another library.