Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ Suggests:
testthat
License: GPL-3 | file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.1
URL: https://rstudio.github.io/reactlog/, https://github.com/rstudio/reactlog, https://community.rstudio.com/tags/reactlog
URL: https://rstudio.github.io/reactlog/, https://github.com/rstudio/reactlog, https://community.rstudio.com/tag/reactlog
BugReports: https://github.com/rstudio/reactlog/issues
VignetteBuilder: knitr
Language: en-US
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# reactlog <a href='https://rstudio.github.io/reactlog/'><img src='man/figures/logo.svg' align="right" height="139" /></a>
# reactlog <a href='https://rstudio.github.io/reactlog/'><img src='man/figures/logo.svg' align="right" style="height: 139px;" /></a>

<!-- badges: start -->
[![R build status](https://github.com/rstudio/reactlog/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/rstudio/reactlog/actions)
Expand Down
88 changes: 15 additions & 73 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,90 +1,32 @@
## CRAN comments
## Comments

#### 2020-9-12
#### 2022-09-19

I've updated the links. Thank you!

Best,
Barret


#### 2020-9-12

Thanks, we see:

```
Found the following (possibly) invalid URLs:
URL: https://community.rstudio.com/c/shiny (moved to
https://community.rstudio.com/c/shiny/8)
From: README.md
Status: 200
Message: OK
URL:
https://resources.rstudio.com/rstudio-conf-2019/reactlog-2-0-debugging-the-state-of-shiny
(moved to
https://rstudio.com/resources/rstudioconf-2019/reactlog-2-0-debugging-the-state-of-shiny/)
From: inst/doc/reactlog.html
Status: 200
Message: OK
URL: https://yarnpkg.com/en/ (moved to https://classic.yarnpkg.com/en/)
From: README.md
Status: 200
Message: OK
URL: https://yarnpkg.com/en/docs/install (moved to
https://classic.yarnpkg.com/en/docs/install)
From: README.md
Status: 200
Message: OK
```

Please change http --> https, add trailing slashes, or follow moved
content as appropriate.

Please fix and resubmit.

Best,
Uwe Ligges

#### 2019-9-11

I've added new features and bug fixes to reactlog.
* Fixed a `{fontawesome}` bug.
* Removed `LazyData: true` from DESCRIPTION.

Please let me know if there is anything else I can provide.

Thank you,
Best,
Barret


## R CMD check results

0 errors | 0 warnings | 0 notes

## Test environments

* local macOS, R 4.0.0
* local macOS, R 4.1.3
* r-hub
* GitHub Actions
* macOS
* oldrel, release, devel
* 4.2
* windows
* release
* ubuntu16
* 3.3, 3.4, 3.5, oldrel, release, devel
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

* devtools::check_win_devel()

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Barret Schloerke <barret@rstudio.com>'
* 4.2
* ubuntu18
* devel, 4.2, 4.1, 4.0, 3.6, 3.5
* devtools::
* check_win_devel()

Possibly mis-spelled words in DESCRIPTION:
Reactivity (2:8)
Schloerke (15:4)
reactivity (16:29)
Status: 1 NOTE
## R CMD check results

* I believe spellings these are false positives.
* `Schloerke` is my last name
* `reactivity` is a word we use to describe how reactive values work within 'shiny'.
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

## revdepcheck results

Expand Down
31 changes: 16 additions & 15 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
# Platform

|field |value |
|:--------|:----------------------------|
|version |R version 4.0.0 (2020-04-24) |
|os |macOS Catalina 10.15.6 |
|system |x86_64, darwin17.0 |
|ui |X11 |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/New_York |
|date |2020-09-03 |
|field |value |
|:--------|:------------------------------|
|version |R version 4.1.3 (2022-03-10) |
|os |macOS Big Sur/Monterey 10.16 |
|system |x86_64, darwin17.0 |
|ui |X11 |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/New_York |
|date |2022-09-26 |
|pandoc |2.19.2 @ /usr/local/bin/pandoc |

# Dependencies

|package |old |new |Δ |
|:--------|:-----|:-----|:--|
|reactlog |1.0.0 |1.1.0 |* |
|reactlog |1.1.0 |1.1.1 |* |

# Revdeps

## All (1)

|package |version |error |warning |note |
|:--------------------------|:-------|:-----|:-------|:----|
|[shiny](problems.md#shiny) |1.5.0 | | |1 |
|package |version |error |warning |note |
|:-------|:-------|:-----|:-------|:----|
|[shiny](problems.md#shiny)|1.7.2 | | |1 |

7 changes: 7 additions & 0 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## revdepcheck results

We checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

15 changes: 7 additions & 8 deletions revdep/problems.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,23 @@

<details>

* Version: 1.5.0
* Version: 1.7.2
* GitHub: https://github.com/rstudio/shiny
* Source code: https://github.com/cran/shiny
* URL: http://shiny.rstudio.com
* BugReports: https://github.com/rstudio/shiny/issues
* Date/Publication: 2020-06-23 13:30:03 UTC
* Number of recursive dependencies: 97
* Date/Publication: 2022-07-19 03:30:02 UTC
* Number of recursive dependencies: 91

Run `revdep_details(,"shiny")` for more info
Run `revdep_details(, "shiny")` for more info

</details>

## In both

* checking installed package size ... NOTE
```
installed size is 11.7Mb
installed size is 10.4Mb
sub-directories of 1Mb or more:
R 2.0Mb
www 8.5Mb
www 7.1Mb
```

4 changes: 2 additions & 2 deletions vignettes/reactlog.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ This vignette explains the **reactlog** interface, which requires a basic unders
* Why a `clientData` is randomly appearing in the reactive graph
* How to prevent reactivity from executing using `isolate()`
* The **shiny** [tutorials](https://shiny.rstudio.com/tutorial/), which provides many great instructional videos and various learning resources.
* The `rstudio::conf2019` talk by Barret Schloerke: _Reactlog 2.0: Debugging the State of Shiny_ ([Video](https://rstudio.com/resources/rstudioconf-2019/reactlog-2-0-debugging-the-state-of-shiny/) / [Slides](https://github.com/schloerke/presentation-2019-01-18-reactlog/blob/master/rstudio-conf-2019-reactlog.pdf)).
* Effective Reactive Programming [Part 1](https://rstudio.com/resources/shiny-dev-con/reactivity-pt-1-joe-cheng/) [Part 2](https://rstudio.com/resources/shiny-dev-con/reactivity-pt-2/):
* The `rstudio::conf2019` talk by Barret Schloerke: _Reactlog 2.0: Debugging the State of Shiny_ ([Video](https://www.rstudio.com/resources/rstudioconf-2019/reactlog-2-0-debugging-the-state-of-shiny/) / [Slides](https://github.com/schloerke/presentation-2019-01-18-reactlog/blob/master/rstudio-conf-2019-reactlog.pdf)).
* Effective Reactive Programming [Part 1](https://www.rstudio.com/resources/shiny-dev-con/reactivity-pt-1-joe-cheng/)) [Part 2](https://www.rstudio.com/resources/shiny-dev-con/reactivity-pt-2/):
* "This tutorial will go beyond the basics, explaining the philosophy behind Shiny’s reactive programming framework and exploring patterns and techniques for using it well."
* [Mastering Shiny](https://mastering-shiny.org) by Hadley Wickham