ensure backslashes in prefix are preserved in list.files hook#10596
Merged
kevinushey merged 4 commits intoprairie-trilliumfrom Feb 14, 2022
Merged
ensure backslashes in prefix are preserved in list.files hook#10596kevinushey merged 4 commits intoprairie-trilliumfrom
kevinushey merged 4 commits intoprairie-trilliumfrom
Conversation
jgutman
reviewed
Feb 14, 2022
kevinushey
commented
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Addresses #10573.
Approach
Ensure that we don't mutate separators within the user-provided path prefix, and ensure we use forward-slashes for any path components constructed following the path prefix.
Automated Tests
Automated tests updated.
QA Notes
Test via notes in:
#10573
#10591
Checklist
NEWS.md