highlight TODO / FIXME comments in R mode#970
Merged
Conversation
Member
|
Anecdotally I tweeted a tip for doing exactly this (using a regex to find TODOs) and it is to date one of the tip top tips tweets. https://twitter.com/rstudiotips/status/811635016903950336 I think it's totally okay for us to highlight these since they're clearly part of the workflow for many customers even if we don't have any other behavior for them yet. |
|
Thank you for adding this. Customers have definitely been talking about this feature for some time now: Highlight-TODO-FIXME-keywords. I am slightly embarrassed how excited I was the moment I noticed the color change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements highlighting of
TODOandFIXMEcomments in R code.The visual effect is nice, but I'm not sure if we want to take this without assigning some actual real behaviors to discovered TODOs. @jmcphers, any thoughts?