Skip to content

Conversation

@nuest
Copy link
Contributor

@nuest nuest commented May 24, 2019

  • add video supplement
  • add sample availability
  • add journals: deuquasp, gchron

Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking: are there CRLF changes in copernicus.cls? I'm curious why the huge diffs and hope to keep the git history as clean as possible (i.e. avoid spurious whitespace changes).

Thank you!

@nuest
Copy link
Contributor Author

nuest commented Jun 2, 2019

I will investigate!

includes switching the line endings from CLRF to LF in file "copernicus.cls"
@nuest
Copy link
Contributor Author

nuest commented Jun 11, 2019

@yihui It was a line endings issue. Should be fixed now.

Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! The diffs are much more meaningful now. Thank you very much!

@yihui yihui merged commit 0491ea5 into rstudio:master Jun 11, 2019
@nuest nuest deleted the copernicus branch June 19, 2019 07:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants