Skip to content

Conversation

@salauer
Copy link
Contributor

@salauer salauer commented Oct 31, 2019

Updated the template for elsevier_article to allow for two authors to share the same footnote (e.g. "these authors made equal contributions") and updated the corresponding skeleton to demonstrate how to use a shared footnote. To do this, I mimicked the style of shared affiliations. (This is my first pull request to an RStudio repo. Any feedback you have for me would be much appreciated!)

… share the same footnote (e.g. "contributed equally"); updated the corresponding skeleton to demonstrate how to use a shared footnote
Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just wonder if the field name fn is clear enough (should we change it to footnote or something else?). Thanks!

@salauer
Copy link
Contributor Author

salauer commented Oct 31, 2019

Good point. I had started with that, but then wasn't sure if there would be some confusion between author.footnote and footnote.code (since author.affiliation links to address.code). I just checked locally and that doesn't appear to be a problem. Do you want to me to submit a new pull request?

@salauer
Copy link
Contributor Author

salauer commented Nov 1, 2019

I think this is ready to be merged.

Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need a news item for this change in NEWS.md. I'll do it myself after merging. Thank you!

@yihui yihui merged commit facd6d4 into rstudio:master Nov 14, 2019
yihui added a commit that referenced this pull request Nov 14, 2019
@wulms
Copy link

wulms commented Feb 13, 2020

What is about multiple footnotes for one author? E.g. the corresponding author contributed equally with another author?

@salauer
Copy link
Contributor Author

salauer commented Feb 13, 2020

@wulms That's a good observation. I had assumed it worked the same way as with affiliations, but it clearly doesn't. Should make an issue for this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants