Fix header inludes for rjournal_article() #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a fix for #257. Perhaps you might want to take a look at the implementation -- because I changed a hacky function into something that's even hackier.
Here is a small example: files.zip. The file
test_needs_include.Rmdwill fail with the current version of rticles and should be solved with this PR.Also, I changed a rasterised image into a vectorised one.
Hope this helps!
Robrecht
Checklist:
Update NEWS.
Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Not applicable
Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
Add the
journalname_article()function toR/article.Rif the output format is simple enough, otherwise create a separateR/journalname_article.R.Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname_article/resources/template.tex.Add a skeleton article
inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.Add a description of the template
inst/rmarkdown/templates/journalname_article/template.yaml.Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. Please keep the number of new files absolutely minimal, and also make examples minimal (e.g., if you need a.bibexample, try to only leave one or two bibliography entries in it, and don't include one hundred items in it without using all of them).Update Rd and namespace (could be done by
devtools::document()).Update README with a link to the newly supported journal.
Add a test to
tests/testit/test-formats.R.