Use only journal name for folder in templates

[cderv]

This will close close #315 and resolve #297 (comment)

The renaming happens in several places. Only user facing change that could be strange: when using rmarkdown::draft, one should use only the journal name now.

Before template is the same as the format name

rmarkdown::draft("MyArticle.Rmd", template = "acm_article", package = "rticles")

Now, it is just the journal name

rmarkdown::draft("MyArticle.Rmd", template = "acm", package = "rticles")

It could be a breaking change for some users who scripted their draft creation.

Should we stick to this solution to resolve #297 (comment) ?

[yihui]

Hmm. I'm not entirely sure if this breaking change is fine (I tend to say yes). Perhaps it can help a little if we provide a helper function to list the available journal names in this package, e.g., rticles::journals().

BTW, I wonder why there are changes in certain .cls and .bib files. I feel these might be CRLF changes from your GIT client on Windows.

• Also remember to update this page: https://bookdown.org/yihui/rmarkdown/rticles-start.html

[cderv]

I'm not entirely sure if this breaking change is fine

I had the same thought. Not sure either but I tend to say yes too because it is easy to fix if someone uses this. Just the template name should be changed. I believe people are creating template through RStudio. But I found a few
https://github.com/search?q=rmarkdown%3A%3Adraft+rticles+language%3AR&type=Code

This changes is also not necessary to resolve the note in #297 as we have other solution.

BTW, I wonder why there are changes in certain .cls and .bib files. I feel these might be CRLF changes from your GIT client on Windows.

You may be right, I will check and configure that correctly.

[cderv]

BTW, I wonder why there are changes in certain .cls and .bib files. I feel these might be CRLF changes from your GIT client on Windows.

I believe this is because we have some commited file on the DOS format. My git setup is core.autocrlf true as I often work with cross platform program, and it is good practice on windows. So when I renamed the path to the file, CRLF (dos format) where converted by git to LF (unix format).

I can revert but do we want DOS format file ?

We could use .gitattributes in the repo to insure that it happens the same for everyone. https://docs.github.com/en/github/using-git/configuring-git-to-handle-line-endings

[yihui]

Okay, let's add the .gitattributes so that the line endings will be consistent in the future when contributors submit pull requests. No need to revert the changes this time. Thanks!

[cderv]

@yihui Two new PR are integrating what is discussed here. To be merged in due time.