Conversation
Owner
|
Agree with all the ideas in your summary. — rswOn Apr 25, 2025, at 6:20 PM, Mats Lidell ***@***.***> wrote:What
Add ibut hypb-smerge
Add smerge to magit-status-mode
Why
It is convenient to use the <<<..., ===... and >>>... lines as
implicit buttons in magit-status-mode and in smerge-mode.
Notes
Docs have not been updated. (Will add that later if we proceed with
this proposal.)
The ibut could go into hibtypes.el since it is small. (It is more a
matter that hibtypes collects many dependencies but might not be an
issue!?)
Maybe the simple name smerge for the ibut is preferred since ibuts
are in their own ibut namespace (or at least prefixed name.)
You can view, comment on, or merge this pull request online at:
#716
Commit Summary
e2df4f8 Add ibut hypb-smerge
8103a2c Add smerge to magit-status-mode
File Changes (5 files)
M
ChangeLog
(10)
M
MANIFEST
(1)
M
Makefile
(4)
A
hib-smerge.el
(48)
M
hui-mouse.el
(28)
Patch Links:
https://github.com/rswgnu/hyperbole/pull/716.patch
https://github.com/rswgnu/hyperbole/pull/716.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Collaborator
Author
Thanks. PR is updated except for the docs part. Stay tuned! |
rswgnu
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
It is convenient to use the <<<..., ===... and >>>... lines as
implicit buttons in
magit-status-modeand insmerge-mode.Notes
this proposal.)
matter that hibtypes collects many dependencies but might not be an
issue!?)
are in their own ibut namespace (or at least prefixed name.)