Conversation
matsl
force-pushed
the
pr_fix_byte_compile_warnings
branch
from
82fa4c1 to
04eaa4e
Compare
rswgnu
reviewed
Mar 2, 2026
hsys-org.el
Outdated
| (require 'org-fold nil t) | ||
| (require 'org-macs) | ||
| (require 'package) | ||
| (require 'package-activate nil t) ; Needed for Emacs >= 31 |
Owner
There was a problem hiding this comment.
When was this introduced into Emacs? Does 'package' not require it? Why have we not seen this warning for months?
Collaborator
Author
There was a problem hiding this comment.
It has been there for a few weeks I think. I did not fix it in my previous warning PR #869. I guess it only shows up in Emacs 31 builds so it is easy to miss and we have been busy with HyWiki things which have had higher prio.
The fix feels a bit dirty but I could not silence the warnings with any other construct. I'm also baffled because package does require it but that does not silence byte compile warning!? Why?
Owner
|
I think you will have to get that issue fixed in Emacs rather than in Hyperbole. I don’t think they would design it to separately require that package.-- BobOn Mar 2, 2026, at 6:53 PM, Mats Lidell ***@***.***> wrote:
@matsl commented on this pull request.
In hsys-org.el:
@@ -40,6 +40,7 @@
(require 'org-fold nil t)
(require 'org-macs)
(require 'package)
+(require 'package-activate nil t) ; Needed for Emacs >= 31
It has been there for a few weeks I think. I did not fix it in my previous warning PR #869. I guess it only shows up in Emacs 31 builds so it is easy to miss and we have been busy with HyWiki things which have had higher prio.
The fix feels a bit dirty but I could not silence the warnings with any other construct. I'm also baffled because package does require it but that does not silence byte compile warning!? Why?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Owner
|
If you eliminate that one require, I'll approve it. -- Bob
…On Mon, Mar 2, 2026 at 7:15 PM Robert Weiner ***@***.***> wrote:
I think you will have to get that issue fixed in Emacs rather than in
Hyperbole. I don’t think they would design it to separately require that
package.
-- Bob
On Mar 2, 2026, at 6:53 PM, Mats Lidell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hsys-org.el
<#882 (comment)>:
> @@ -40,6 +40,7 @@
(require 'org-fold nil t)
(require 'org-macs)
(require 'package)
+(require 'package-activate nil t) ; Needed for Emacs >= 31
It has been there for a few weeks I think. I did not fix it in my previous
warning PR #869 <#869>. I guess
it only shows up in Emacs 31 builds so it is easy to miss and we have been
busy with HyWiki things which have had higher prio.
The fix feels a bit dirty but I could not silence the warnings with any
other construct. I'm also baffled because package does require it but that
does not silence byte compile warning!? Why?
—
Reply to this email directly, view it on GitHub
<#882 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPDYT4XJVINF5TY4WBET4OYNHZAVCNFSM6AAAAACWEYVP7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNZZGQZTMOBXGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
* hywiki.el (consult--async-command): (consult--lookup-member): (consult--read): Declare functions.
matsl
force-pushed
the
pr_fix_byte_compile_warnings
branch
from
04eaa4e to
a04bcb2
Compare
Collaborator
Author
OK. I'll remove that fix and ask in emacs-devel about it. |
rswgnu
approved these changes
Mar 3, 2026
Owner
|
PR approved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Silence byte compile warnings.
(consult--lookup-member):
(consult--read): Declare functions.
Why
Compilation should be clean and silent.