Merged
Conversation
rswgnu
approved these changes
Mar 15, 2026
* Makefile (coverage): enable-local-variables :all so test suite can execute
with no user interaction.
matsl
force-pushed
the
pr_set_enable-local-variables_for_covarage_target
branch
from
17c5825 to
19f6ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow local variables in coverage target
with no user interaction.
Why
The coverage target uses the test suite for creating the coverage
information. With dir local variables in .dir-locals.el it can lead to
that the test suite halts and waits for confirmation. The PR proposes
to use a wide setting and allow all but could probably be set to just
ignore local variables if we think it could be a security concern.