Add hyrolo test case for moving in fgrep result#932
Conversation
* test/hyrolo-tests.el (hyrolo-tests--fgrep-move-test): Add test case for moving in *HyRolo* buffer after fgrep search. Test is set as expected failed since there is a problem with moving over hidden sections.
|
@matsl Why don't you put the tests that fail at the beginning of the test sequence so when edebugging you don't have to step through all the known good tests to see one that is failing. |
|
@matsl The HyRolo display buffer now contains text-properties to speed movement. You can no longer manually add text to build such buffers. You must find a start-end region in the source buffer and call hyrolo-add-match to add it to the HyRolo buffer to construct it correctly. Try updating your code and then running tests. SORRY, I misread your code. I see you do use hyrolo-fgrep to construct the HyRolo display buffer so let me have a deeper look of why it doesn't seem to have the right text properties in it. |
|
I found the movement problem. I'll deploy your PR, remove the expected fail, apply my movement fix and then push to master with your test working. |
When debugging I just comment out the test that works so only the failing test is remaining. It works quite well when using ert-info to wrap each test so it is easy to comment out. I think it is good to have a set of working tests that sort of proves that the test setup is doing the right thing. An alternative could be to add the failing test as a separate ert-test that we later merge with the ert-test with the good test cases!? That would make it possible to have more than one failing test. WDYT? |
What
Add hyrolo test case for moving in fgrep result.
for moving in HyRolo buffer after fgrep search. Test is set as
expected failed since there is a problem with moving over hidden
sections.
Why
More tests and shows a possible bug.