Merged
Conversation
- Add docstring linting with numpy-style convention - Replace broad exception handlers with specific types - Update to modern dependency-groups syntax - Fix test and coverage paths in pyproject.toml - Add comprehensive developer documentation - Standardize markdown formatting - Remove unused root-level files
7f3fe8d to
353d7c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Code Quality and Documentation
This PR adds code quality tooling and expands developer documentation on top of the existing development environment setup. It also incorporates the latest changes from upstream, including the new qsm-medi gear.
What's New in This PR
Code Quality Enhancements
ImageUploading/fwImageUpload.pyexcept Exceptionwith specific exception types (OSError,ValueError,flywheel.ApiException,KeyError,AttributeError,zipfile.BadZipFile) for better error diagnosis and debuggingBLErule to prevent overly broad exception handlersConfiguration Improvements
[dependency-groups]syntax (replacing deprecated[tool.uv])ImageUploading/testsandQSMxT/testsfw-client>=0.1.0as explicit dependencyDocumentation
-instead of+) and arrows (→instead of=>)uvfor dependency management, testing, and lintingRepository Cleanup
main.py, empty__init__.py)Upstream Integration
Testing
Benefits
These changes provide:
All changes are backward compatible with existing functionality.
Critical: This repository still contains an exposed Flywheel API key in its git history (commit
1849112from December 2025). While the key was replaced with a placeholder in commit0cba685, it remains accessible in the repository's history.Immediate Actions Required
Cleaning Git History
Install git-filter-repo (recommended method):
Then clean the repository:
Note: After force-pushing, all collaborators will need to re-clone the repository or reset their local copies.
Alternative: Using BFG Repo-Cleaner