fix: preserve state when Enable All sites#57
Merged
justlevine merged 1 commit intodevelopfrom Nov 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the "Enable All" toggle functionality in the Site Settings screen to preserve the previously selected searchable sites when re-enabling sites, rather than resetting them to defaults.
Key Changes:
- Modified bulk toggle logic to restore previous
searchable_sitesselections when enabling sites - Added filtering to ensure only sites with valid entities are preserved
- Updated ESLint ignore pattern for better coverage of build directories
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/src/components/SiteSearchSettings.js | Implements state preservation logic in handleBulkToggle to restore previous searchable_sites when enabling, filtering out sites without entities |
| .eslintignore | Updates build directory ignore pattern from build/* to **/build/** for more comprehensive coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
Enable Alltoggle on the Site Settings screen to preserve the state when toggling.Technical Details
Checklist
Screenshots
To-do
Fixes/Covers issue