Skip to content

fix: preserve state when Enable All sites#57

Merged
justlevine merged 1 commit intodevelopfrom
fix/site-settings-toggle
Nov 12, 2025
Merged

fix: preserve state when Enable All sites#57
justlevine merged 1 commit intodevelopfrom
fix/site-settings-toggle

Conversation

@justlevine
Copy link
Collaborator

Description

This PR fixes the Enable All toggle on the Site Settings screen to preserve the state when toggling.

Technical Details

Checklist

Screenshots

To-do

Fixes/Covers issue

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the "Enable All" toggle functionality in the Site Settings screen to preserve the previously selected searchable sites when re-enabling sites, rather than resetting them to defaults.

Key Changes:

  • Modified bulk toggle logic to restore previous searchable_sites selections when enabling sites
  • Added filtering to ensure only sites with valid entities are preserved
  • Updated ESLint ignore pattern for better coverage of build directories

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
assets/src/components/SiteSearchSettings.js Implements state preservation logic in handleBulkToggle to restore previous searchable_sites when enabling, filtering out sites without entities
.eslintignore Updates build directory ignore pattern from build/* to **/build/** for more comprehensive coverage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@justlevine justlevine merged commit 84bc74a into develop Nov 12, 2025
15 checks passed
@justlevine justlevine deleted the fix/site-settings-toggle branch November 12, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant