Skip to content

Fix: mismatched TextEditor component styles#184

Merged
ayushnirwal merged 1 commit intofeat/text-editor-migratefrom
fix/text-editor-styles
Jan 30, 2026
Merged

Fix: mismatched TextEditor component styles#184
ayushnirwal merged 1 commit intofeat/text-editor-migratefrom
fix/text-editor-styles

Conversation

@b1ink0
Copy link
Collaborator

@b1ink0 b1ink0 commented Jan 30, 2026

Description

This PR aligns TextEditor component styles with Frappe UI TextEditor component styles.

Relevant Technical Choices

Styles are referenced from : https://github.com/frappe/frappe-ui/blob/ee7076a4c427c43071404419bd6008ad845b06da/tailwind/plugin.js#L276-L393

Screenshot/Screencast

Before After
Screenshot 2026-01-30 at 4 40 01 PM Screenshot 2026-01-30 at 4 39 22 PM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the TextEditor component styles with the Frappe UI TextEditor component styles to ensure visual consistency between the two libraries.

Changes:

  • Added heading font weight rules to standardize heading typography
  • Added image alignment utilities for right and center alignment
  • Added comprehensive prose-sm variant styles with custom font sizing, spacing, and list formatting

@b1ink0 b1ink0 requested a review from ayushnirwal January 30, 2026 11:16
@ayushnirwal ayushnirwal merged commit faed0e5 into feat/text-editor-migrate Jan 30, 2026
7 checks passed
@b1ink0 b1ink0 deleted the fix/text-editor-styles branch January 30, 2026 12:57
@ayushnirwal ayushnirwal added this to the v1.1.0 milestone Feb 2, 2026
b1ink0 pushed a commit that referenced this pull request Feb 3, 2026
Fix: mismatched TextEditor component styles
b1ink0 pushed a commit that referenced this pull request Feb 3, 2026
Fix: mismatched TextEditor component styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants