Sync Develop to Main for 1.4.2 Release #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: Update changelog and version to 1.4.1 (#1130) * Hotfix/analytics gallery (#1133) * Revert "Fix - Analytics tracking for dynamically rendered videos (#1105)" This reverts commit 835226f. * docs: Remove reverted analytics commit from changelog --------- Co-authored-by: Subodh Rajpopat <subodh.rajpopat@rtcamp.com>
sync develop with main after release 1.4.1
…1142) * New sequence for media src HLS, MPD, Original URL to fix safari Audio mute issue * Provide HLS URL support on [godam_video] shortcode --------- Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
…1126) * fix: allow only image upload * remove unused code * update snackbar message
* FIX: Remove `filemtime` warnings * FEAT: Close autoadvance upon `x` button click
* Implement WordPress video replacement with mp4 source * Use add_attachment hook to send transcoding request, instead of wp_generate_attachment_metadata * Address the PR feedback --------- Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
* fix: Analytics for GoDAM Gallery with Helper Function * docs: Add comments for helper function * fix: Avoid sending analytics data on admin and preview pages * fix: Avoid duplicate player initialization
* Add repackaging step for WordPress plugin ZIP * Use `runner.temp` for temp folder location Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Give path for Test upload artifact and not file It can zip and do it already --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the develop branch to main for the 1.4.2 release, implementing several key bug fixes and enhancements for video playback, transcoding, analytics, and third-party integration compatibility.
- Fixed video source prioritization to prefer HLS over DASH for better browser compatibility
- Resolved LifterLMS integration path issues and added security improvements with DOMPurify
- Restored analytics tracking for GoDAM Gallery videos and admin page detection
- Enhanced media library with MP4 replacement functionality and improved error handling
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| inc/templates/godam-player.php | Updated video source handling and HLS/DASH prioritization |
| inc/classes/lifter-lms/class-lifter-lms.php | Fixed file path references for LifterLMS integration scripts |
| inc/classes/class-media-library-ajax.php | Added MP4 transcoded video replacement functionality |
| assets/src/js/lifterlms/block.js | Added DOMPurify sanitization and countdown management |
| assets/src/js/godam-player/video-analytics-plugin.js | Added admin page detection to skip analytics |
| assets/src/js/godam-gallery.js | Restored video analytics tracking for gallery interactions |
| admin/class-rtgodam-transcoder-handler.php | Changed transcoding trigger from metadata generation to attachment addition |
| assets/src/blocks/godam-player/edit.js | Reordered video source prioritization for HLS-first playback |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KMchaudhary
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: