fix: Add conditional accessing + regression issue#1682
Merged
subodhr258 merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dashboard charts component to defensively handle missing plays values when rendering the plays metric, avoiding runtime errors when plays is null/undefined.
Changes:
- Apply a
plays ?? 0fallback when formatting the plays metric for display. - Apply a
plays ?? 0fallback when computing thetitletooltip value viatoLocaleString().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
subodhr258
changed the title
subodhr258
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - https://github.com/rtCamp/godam-core/issues/779
This pull request makes a small change to how the
playsvalue is handled in the dashboard chart component, ensuring that null or undefined values are safely formatted and displayed as zero.main()withinChartsDashboard.jsto useplays ?? 0when formatting and setting the title, preventing issues whenplaysis null or undefined.