Sync main with develop after 1.8.0 release#1838
Conversation
1.8.0 Release
fix: Add 410 Gone redirect for CPT URLs
…ment_feature" filter (#1832) * Revert the GoDAM engagement features * feat: Add support for engagements parameter in video embed functionality * Add rtgodam_enable_engagement_feature hook to Enable engagement feature conditionally across video and gallery components * fix: Adjust handling of 'engagements' attribute for correct boolean parsing * Resolve copilot comments * fix: Update migration for engagements feature * fix: Update engagement defaults * Fix the engagment for non-transcoded videos, and non valid api key * Revert "fix: Update engagement defaults" This reverts commit 1f3289e. * Fix the status comparison by converting to lowercase --------- Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com> Co-authored-by: Subodh Rajpopat <subodh.rajpopat@rtcamp.com>
* fix: Automatically migrate all subsites * fix: Migrate on init hook
rtBot
left a comment
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
Powered by rtCamp's GitHub Actions Library
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 inc/templates/godam-player.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
146 |
WordPress.DB.SlowDBQuery.slow_db_query_meta_key | Detected usage of meta_key, possible slow query. |
📁 readme.txt (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/04/demo-post-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-page-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/04/demo-post-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-page-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
There was a problem hiding this comment.
Pull request overview
Syncs main with develop for the 1.8.0 release by aligning version metadata, documenting the release, and wiring the new (feature-flagged) engagement functionality through embeds/blocks/settings while updating migration behavior.
Changes:
- Bumps plugin/package “stable tag” and version references to 1.8.0, and adds 1.8.0 changelog entries.
- Introduces an engagement feature gate and propagates engagement enablement through settings UI, blocks (player + gallery v2), shortcodes, and the embed experience.
- Updates migrations to run on
init, improves multisite handling, and adds a 410 handler for legacy CPT URLs after cleanup.
Reviewed changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updates stable tag and adds v1.8.0 changelog entry. |
| README.md | Updates stable tag to 1.8.0. |
| CHANGELOG.md | Adds v1.8.0 release notes. |
| godam.php | Updates plugin header + RTGODAM_VERSION to 1.8.0; cleans uninstall transient. |
| package.json | Sets package version to 1.8.0. |
| package-lock.json | Updates lockfile package version entries to 1.8.0. |
| inc/helpers/custom-functions.php | Adds rtgodam_is_engagement_feature_enabled() and extends embed helper to support engagements; updates @since tags. |
| inc/classes/class-assets.php | Localizes engagementFeatureEnabled and gates global engagement setting in JS config. |
| pages/godam/components/tabs/VideoSettings/VideoEngagement.jsx | Adds feature-flagged “global engagement” toggle. |
| assets/src/blocks/godam-player/block.json | Adds engagements attribute to player block. |
| assets/src/blocks/godam-player/edit-common-settings.js | Adds engagements toggle, gated by feature + global setting. |
| assets/src/blocks/godam-gallery-v2/block.json | Adds engagements attribute (default true) to gallery v2. |
| assets/src/blocks/godam-gallery-v2/edit.js | Adds engagements toggle, gated by feature + global setting. |
| assets/src/blocks/godam-gallery-v2/render.php | Outputs engagement state into gallery dataset for frontend modal embed. |
| assets/src/blocks/godam-gallery-v2/view.js | Appends engagements=show to embed URL when enabled. |
| inc/templates/video-embed.php | Parses engagements request param and passes through to embed renderer with gating. |
| assets/src/js/godam-video-embed.js | Adds embed-page comment box bootstrap when engagements are enabled. |
| inc/classes/shortcodes/class-godam-player.php | Normalizes engagements shortcode attribute (treats 'show' as true). |
| inc/classes/shortcodes/class-godam-video-gallery.php | Gates gallery engagements output on feature flag. |
| inc/classes/rest-api/class-dynamic-shortcode.php | Sanitizes/validates engagements param and escapes shortcode args. |
| inc/classes/rest-api/class-dynamic-gallery.php | Gates REST-rendered gallery engagements on feature flag. |
| inc/classes/class-video-engagement.php | Adds early return when engagement feature is disabled. |
| pages/video-editor/index.js | Makes global component/action merges resilient when window vars are unset. |
| pages/video-editor/components/layers/Layer.js | Localizes fallback/loading strings via @wordpress/i18n. |
| pages/godam/App.js | Comments out Woo integrations tab/import wiring in settings UI. |
| inc/classes/class-plugin.php | Comments out Addon registry bootstrapping (Woo-related). |
| admin/class-rtgodam-transcoder-admin.php | Comments out Woo promo notice wiring. |
| inc/templates/godam-player.php | Renames internal temp vars for clarity/prefix consistency. |
| assets/src/blocks/godam-player/edit.js | Avoids deriving width from percentage heights. |
| inc/classes/migrations/class-runner.php | Moves migration trigger to init, adds multisite sweep, and requires migrations to report completion. |
| inc/classes/migrations/class-gallery-v1-to-v2.php | Updates migration to return completion status and passes through engagements attribute. |
| inc/classes/migrations/class-godam-cpt-cleanup.php | Adds 410 redirect handling post-cleanup; updates to return status and adds multisite-safe AS job context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.