Update the webpack config and package.json by KMchaudhary · Pull Request #2 · rtCamp/godam

KMchaudhary · 2024-12-11T09:10:02Z

Update the package.json and webpack that will work as a base for easyDAM features development.
Add EasyDAM Video block.

Update the package.json and webpack that will wor k as a base for easyDAM features development

rtBot

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 16 errors

skipped-files

Maximum number of lines exceeded (15000):

assets/build/blocks/easydam-player/frontend.js
assets/build/blocks/easydam-player/index.js

Note that the above file(s) were not analyzed due to their length.

Powered by rtCamp's GitHub Actions Library

Posting will continue in further review(s)

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'e2d23771ba2d814f829e');


🚫 Error: Missing file doc comment (Squiz.Commenting.FileComment.Missing).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'e2d23771ba2d814f829e');


🚫 Error: Expected 1 space after the array opener in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'e2d23771ba2d814f829e');


🚫 Error: When a multi-item array uses associative keys, each value should start on a new line (WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'e2d23771ba2d814f829e');


🚫 Error: Expected 1 space before the array closer in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserSingleLine).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-blob', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives'), 'version' => 'c3fda1483d8ff073fe8d');


🚫 Error: Missing file doc comment (Squiz.Commenting.FileComment.Missing).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-blob', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives'), 'version' => 'c3fda1483d8ff073fe8d');


🚫 Error: Expected 1 space after the array opener in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-blob', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives'), 'version' => 'c3fda1483d8ff073fe8d');


🚫 Error: Expected 1 space before the array closer in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserSingleLine).

rtBot · 2024-12-11T09:11:07Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-blob', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives'), 'version' => 'c3fda1483d8ff073fe8d');


🚫 Error: When a multi-item array uses associative keys, each value should start on a new line (WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound).

rtBot · 2024-12-11T09:11:08Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => '6ceb6cf9faa42622bc89');


🚫 Error: Missing file doc comment (Squiz.Commenting.FileComment.Missing).

rtBot · 2024-12-11T09:11:08Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => '6ceb6cf9faa42622bc89');


🚫 Error: Expected 1 space after the array opener in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine).

rtBot

Previous scan continued.

rtBot · 2024-12-11T09:11:09Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => '6ceb6cf9faa42622bc89');


🚫 Error: When a multi-item array uses associative keys, each value should start on a new line (WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound).

rtBot · 2024-12-11T09:11:10Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => '6ceb6cf9faa42622bc89');


🚫 Error: Expected 1 space before the array closer in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserSingleLine).

rtBot · 2024-12-11T09:11:10Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'd30a32a27c47da7979ee');


🚫 Error: Missing file doc comment (Squiz.Commenting.FileComment.Missing).

rtBot · 2024-12-11T09:11:10Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'd30a32a27c47da7979ee');


🚫 Error: Expected 1 space after the array opener in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine).

rtBot · 2024-12-11T09:11:10Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'd30a32a27c47da7979ee');


🚫 Error: When a multi-item array uses associative keys, each value should start on a new line (WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound).

rtBot · 2024-12-11T09:11:10Z

@@ -0,0 +1 @@
+<?php return array('dependencies' => array(), 'version' => 'd30a32a27c47da7979ee');


🚫 Error: Expected 1 space before the array closer in a single line array. Found: no spaces (NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserSingleLine).

- Add permissions block to phpcs_on_pull_request.yml (contents: read, pull-requests: write) - Add permissions block to release_on_tag.yml (contents: write) - Add permissions block to deploy_on_push.yml (contents: read) This follows the principle of least privilege and resolves GitHub code scanning alerts #1, #2, and #3. Fixes: rtCamp/support#245

Update the webpack config and package.json

79ca3c9

Update the package.json and webpack that will wor k as a base for easyDAM features development

KMchaudhary requested a review from elifvish December 11, 2024 09:10

KMchaudhary self-assigned this Dec 11, 2024

rtBot requested changes Dec 11, 2024

View reviewed changes

elifvish approved these changes Dec 11, 2024

View reviewed changes

Add paths to exlude phpcs

9b8c616

KMchaudhary merged commit 371908f into master Dec 11, 2024

KMchaudhary deleted the feat/webpack-config branch March 10, 2025 03:18

subodhr258 mentioned this pull request May 20, 2026

Batch type 1 page_load events + gate observer teardown on success #1878

Merged

elifvish mentioned this pull request May 25, 2026

feat: Add Virtual Media Registrar and Migration classes for handling virtual media integration #1784

Merged

		@@ -0,0 +1 @@
		<?php return array('dependencies' => array(), 'version' => 'e2d23771ba2d814f829e');

Conversation

KMchaudhary commented Dec 11, 2024

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants