Fix: Ensure video speed and quality settings are player-specific #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where video speed and quality settings were applied globally across all video player instances instead of being player-specific. The changes remove global state variables and implement instance-specific settings storage.
- Replaced global
selectedSpeedandselectedQualityvariables with player instance properties - Removed DOM loop that incorrectly applied playback rate changes to all video players on the page
- Added initialization of default values for speed and quality settings in the constructor
Contributor
|
Hi @karthikeya-io, Can you please resolve the copilot feedbacks? |
hbhalodia
approved these changes
Aug 8, 2025
Mukulsingh27
approved these changes
Aug 8, 2025
subodhr258
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Fix: Ensure video speed and quality settings are player-specific * Refactor: Use logical nullish assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Details
selectedSpeedandselectedQualityas properties on the player instance.Screen.Recording.2025-08-07.at.6.59.37.PM.mov